Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

Support for assessment format version: stage 2 (p-a) #335

Open
3 tasks
AloisMahdal opened this issue Oct 25, 2017 · 2 comments
Open
3 tasks

Support for assessment format version: stage 2 (p-a) #335

AloisMahdal opened this issue Oct 25, 2017 · 2 comments

Comments

@AloisMahdal
Copy link
Collaborator

AloisMahdal commented Oct 25, 2017

This is part of a greater change that needs to be done in all three codebases in 3 stages:

  • 1. preupgrade-assistant-modules (#31),
  • 2. preupgrade-assistant (this ticket),
  • 3. redhat-upgrade-tool (#31).

Below is the complete description:


Assessment, as a data object does not currently have any concept of versioning. Any tools that further work with it (redhat-upgrade-tool, preupg-kickstart-creator, preupg UI...) simply have to assume that they "understand" the data.

The solution is to introduce assessment format version. The flow is:

  • Module set declares its abability to produce assessment in version $V. This can be done
    by means of key/value pair in properties.ini

    assessment_format_version = 0.1
    
  • Assisstant launches modules and passes this information as part of assessment
    somewhere under (/root/preupgrade as well as in tarball).

  • redhat-upgrade-tool hardcodes range of versions (actually just one particular version)
    it's able to "understand" and compares this against assessment version. If the versions
    match, it can continue. If the versions don't match or assessment version cannot be
    determined, it advises user to install respective module set and re-run assessment.

@bocekm
Copy link
Collaborator

bocekm commented Oct 26, 2017

@AloisMahdal, @pirat89, do you expect to have this implemented till the batch 6? I don't think it's realistic.

@pirat89
Copy link
Collaborator

pirat89 commented Oct 26, 2017

Hmm... not sure... I know just one thing, that I need resolve rpm dependencies. But I would help you with that in PA, in case I will have time and you will be able to implement this inside r-u-t then.. Then we can see, whether we it will be prepared or not. But agree, that in case it should be part of the batch, it should be implemented during the next week in the worst case.

@AloisMahdal AloisMahdal changed the title Support fof assessment format version: stage 2 (p-a) Support for assessment format version: stage 2 (p-a) Oct 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants