Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Parallel Screens #10

Open
smngr opened this issue Apr 8, 2021 · 1 comment
Open

Use of Parallel Screens #10

smngr opened this issue Apr 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@smngr
Copy link
Collaborator

smngr commented Apr 8, 2021

I've noticed that the Parallel Screens class doesn't check the size of the input array, so if you give it (t, x1, y1, z1, x2, y2, z2) then it inserts more separation columns. This leads to confusion for some users who now have a 9-column LOR array. Perhaps catching this and warning the user would be useful.

@smngr smngr added the enhancement New feature or request label Apr 8, 2021
@anicusan
Copy link
Member

anicusan commented Apr 8, 2021

We have relaxed the requirement for LineData to have exactly 7 columns to allow users to have any other attributes as extra columns, same as with PointData. But I see your point on how people might use ParallelScreens with lines that already have 7 columns formatted as [time, x1, y1, z1, x2, y2, z2] (which should go into the standard LineData directly).

I will add a warning when ParallelScreens is instantiated with data that has exactly 7 columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants