Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extractProtocol method takes too much time #179

Open
adityapatadia opened this issue Jun 11, 2019 · 2 comments
Open

extractProtocol method takes too much time #179

adityapatadia opened this issue Jun 11, 2019 · 2 comments

Comments

@adityapatadia
Copy link

Hi have integrated this library but it seems the extractProtocol method takes about 42 ms of total 54 ms execution time. Please check the screenshot attached.

Screenshot 2019-06-11 at 4 21 54 PM
@adityapatadia
Copy link
Author

It would be good if we can improve the regex or use browser native method whenever available: https://developer.mozilla.org/en-US/docs/Web/API/URL

@3rd-Eden
Copy link
Member

Feel free to create a PR with the suggested performance improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@3rd-Eden @adityapatadia