Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES Modules #168

Open
lastmjs opened this issue Mar 1, 2019 · 5 comments
Open

ES Modules #168

lastmjs opened this issue Mar 1, 2019 · 5 comments

Comments

@lastmjs
Copy link

lastmjs commented Mar 1, 2019

It would be great for url-parse to provide an ES module output. Thanks!

@lastmjs
Copy link
Author

lastmjs commented Mar 1, 2019

Let me know what you think of the idea, and if a PR would be accepted. There are a few things to discuss if you would like to incorporate this.

@3rd-Eden
Copy link
Member

So you want that in addition to the module.exports output? Most systems that are available today are perfectly capable of handling both. What would be the main reason to expose ES module output?

@lastmjs
Copy link
Author

lastmjs commented Apr 11, 2019

I want to use ES modules in the browser without bundlers or complicated build steps, also the ecosystem is moving to ES modules

@coder925
Copy link

When I'm building in Angular (v10), I receive a warning:

WARNING in C:\Temp\MyApp\src\app\app.component.ts depends on 'url-parse'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Would a PR for this request also remove this warning?

@MatthiasKunnen
Copy link

@coder925, yes it will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants