Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 cents to nice plugin #35

Open
Puppin opened this issue May 25, 2019 · 1 comment
Open

5 cents to nice plugin #35

Puppin opened this issue May 25, 2019 · 1 comment
Labels
bug Something isn't working enhancement New feature or request
Projects

Comments

@Puppin
Copy link

Puppin commented May 25, 2019

Hi there. Playing around find some good things to add

             key: "getValues",
              value: function getValues() {
                var x, y;
                **var isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);**
                if (this.isMobile()) {
                  **if (isSafari == true) {
                    x = this.event.accelerationIncludingGravity.x / -4;
                    y = this.event.accelerationIncludingGravity.y / 4;**
                    } else {
                      x = this.event.accelerationIncludingGravity.x / 4;
                      y = this.event.accelerationIncludingGravity.y / -4;
                    }                    
                  var stateX, stateY;

This makes equal behavior on iPhones and Android devices. I guess -4 makes right movement depends on device orientation.

'background-image': 'radial-gradient(circle at bottom center, rgba(252,253,255,1) 20%,rgba(255,255,255,0) 60%)', parameters for shine gradient looks better for me.

Also it will be great to move the card by finger on mobile in addition to device orientation movement. And filter acceleration data of course lol.

And finally small question. I didn't get easing for shine rotation. It was possible to make it in previous versions (like in demo page). But now it unfortunately does not work. Quick shine rotation on mobile absolutely not cool and looks glitching.

@JB1905
Copy link
Collaborator

JB1905 commented May 25, 2019

Thank you for the suggestions for improvements. I'll try to take a look at them next week.

@JB1905 JB1905 added bug Something isn't working enhancement New feature or request labels May 25, 2019
@JB1905 JB1905 added this to Consider in Next Aug 10, 2019
@JB1905 JB1905 moved this from Consider to To do in Next Nov 1, 2021
@JB1905 JB1905 added this to In progress in 2020 Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
2020
  
In progress
Next
  
To do
Development

No branches or pull requests

2 participants