Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAC Data Keys update #109

Closed
11 of 12 tasks
Tracked by #129
mike-gangl opened this issue Jan 16, 2024 · 10 comments
Closed
11 of 12 tasks
Tracked by #129

STAC Data Keys update #109

mike-gangl opened this issue Jan 16, 2024 · 10 comments
Assignees
Labels
Feature Feature label used in Unity Project U-DS U-UIUX

Comments

@mike-gangl
Copy link
Contributor

mike-gangl commented Jan 16, 2024

STAC Data Keys Updates

Currently we use STAC asset keys of "data", "metadata" and others. This disallows the usage of multiple "data" types as an asset, which breaks the SBG workflows that contain multiple data workflows.

Acceptance Criteria

Work Tickets

Dependencies

  • TBD

Risks

@mike-gangl mike-gangl self-assigned this Jan 16, 2024
@mike-gangl mike-gangl added U-DS U-UIUX Feature Feature label used in Unity Project labels Jan 16, 2024
@mike-gangl
Copy link
Contributor Author

Need to have a discussion with @rtapella and @ngachung on the timing of this release.

  • Timing of deployment of DAPA Search result updates
  • Timing of deployment of DAPA ingest updates
  • Timing of availability of new Stage-in tasks
  • Timing of availability of new Stage-out tasks
  • Timing of availability of unity-py Stac utilities updates
  • Update application packages with unity py updates, stage-in, out docker containers

@GodwinShen
Copy link

@ngachung which work tickets are associated with the acceptance criteria shown below?

  • STAC asset key is not based on "data" or "metadata" - should be unique and not known ahead of time and based on filename
  • Ingest commands can ingest multiple "data" role types successfully
  • file a ticket with CMR to use the asset-role in their results"

@GodwinShen
Copy link

@mike-gangl is this something that you would do? If so, I guess we should have a ticket for it if you don't already have one elsewhere: Existing Workflows are updated to use new stage-in/out containers

@GodwinShen
Copy link

@rtapella , @anilnatha do we have a ticket for this item yet? "Create validation STAC outputs from unity-py". The work tickets listed here don't immediately look applicable to me, but that could just be my lack of understanding.

@rtapella
Copy link
Collaborator

Good question. I am not sure what that means exactly or who would do it. Does it mean testing that this works? (specifically taht tickets 67 and 69 in unity.py work, the first two checkboxes)

@GodwinShen
Copy link

@mike-gangl what do we mean by the task "Create validation STAC outputs from unity-py"? I don't know if this is something we need UI/UX to do or what. Can you help clarify this one?

@mike-gangl
Copy link
Contributor Author

mike-gangl commented Jan 29, 2024

Open question- how can we inform U-DS which file is the stac-json file to read metadat from. Consider the case where we have multiple metadata file ending with .json?

data_file.tiff (role: data)
data_file.met.json (role: metadata)
data_file.json (role: metadata, stac, u-ds needs this one)
data_file.mdf (role: metadata)
data_file.png (role: browse)

I wonder if we should call the file data_file.stac.json so we have a good indication of what to key off of? in this case, we can set the cumulus configuration to look for *.stac.json files

@ngachung thoughts?

@ngachung
Copy link

We can standardize on data_file.stac.json, but for now our implementation as described in unity-sds/unity-data-services#301 is to parse all the json files until we get a valid stac feature.

@mike-gangl
Copy link
Contributor Author

@GodwinShen - regarding "Validation Outputs" means to work with U-DS to ensure the output files from to_stac() are valid from the U-DS perspective. This is for stage-out and the ingestion portions of stac.

@rtapella
Copy link
Collaborator

marked Done but never Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature label used in Unity Project U-DS U-UIUX
Projects
Status: Done
Development

No branches or pull requests

4 participants