Uniswap v4 support #337
Comments
|
I've just read whitepaper, so it's kinda challenging to determine further development. From what I understand, they intend to drop old pools in favor of singleton contract. Most probably, liquidity providers will tend to migrate there as uni team declares pretty much attractive features for this contract. Hence, uni v2 and v3 pools will follow v1. I think we should wait for testnet deployment. At that moment it will be much easier to understand what way we should consider. Regarding participation, I'd like to but I literally reside in Ukraine, so it's kinda hard to predict. |
|
@liquid-8 Oh shit, didn't realize. If I can help in anyway, don't hesitate to ask. I'm also eager for a testnet deployment, just wanted to send out notice well in advance :) |
|
Someone YOLO-deployed v4 to Goerli: https://twitter.com/_prestwich/status/1669851049757401088 |
|
That's fine. It is possible now to make some drafts, at least. Also, I share your idea to ship that as a separate package. I doubt that we have to pay attention to the older versions from now on. However, there are plenty of v2/v3 clones; therefore, there is no need to purge previous versions' support from the codebase. |
|
I agree a separate package is a good approach here - can leave the older versions untouched as Im sure most would try to migrate to v4 (given the optionality hooks could provide). Haven't dived into the whitepaper yet but definitely intrigued. Ill probably set aside some time and take a look this week. |
Also, test deployment from Uni team at Sepolia |
Uniswap v4 was recently announced: https://blog.uniswap.org/uniswap-v4
My commitment
I'm not sure how much time I'll have to work on it myself, but I am at minimum open to helping out with reviewing PRs etc.
Plan
Not sure if we should go for a full rewrite this time
and rip out the v1/v2/v3 support (to clean up the codebase), perhaps ship it as a separate packageuniswap-python-v4.For now, we will work in the dev/v4 branch and make a new class to instantiate for v4. This seems like a good solution.
Work so far can be seen here: #340
Funding
I assume we will be able to acquire funding for this, given the Uniswap Grants Program (UGP) was satisfied with our work in the past. (as was Adam)
Misc
Might want to include example for hooks, here's one for example that sets trading hours in a silly way: https://twitter.com/eth_call/status/1675860109342253059
@shanefontaine @liquid-8 @KeremP
The text was updated successfully, but these errors were encountered: