FIXME from the code

[rfreis]

Hi. Congratulations for your job done!

Just looking at the repository and as I'm working and understanding the same issue of this line comment

uniswap-python/uniswap/uniswap.py

Line 336 in 7a90811

# FIXME: How to calculate this properly? See https://docs.uniswap.org/reference/libraries/SqrtPriceMath

• I decided to share what I was able to find

q96 = 2**96
def price_to_sqrtp(p):
    """
    Code from https://uniswapv3book.com/docs/milestone_1/calculating-liquidity/
    """
    return int(math.sqrt(p) * q96)

[ErikBjare]

Could you make a PR with this change? :)

…

On Thu, Aug 17, 2023, 09:55 Xaks ***@***.***> wrote: thx — Reply to this email directly, view it on GitHub <#344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKXDORGK5NV4B4UIDAQSE3XVXE5XANCNFSM6AAAAAA3RZON44> . You are receiving this because you are subscribed to this thread.Message ID: <uniswap-python/uniswap-python/repo-discussions/344/comments/6748426@ github.com>

[ErikBjare]

Why do the bots keep spamming this thread?!