Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a location for Pattern_White_Space #1

Open
erickt opened this issue Mar 16, 2016 · 1 comment
Open

Find a location for Pattern_White_Space #1

erickt opened this issue Mar 16, 2016 · 1 comment

Comments

@erickt
Copy link
Contributor

erickt commented Mar 16, 2016

rustc_unicode recently added support for Pattern_White_Space in rust-lang/rust@24578e0. Syntex needs this support somewhere, and @kwantam mentioned that unicode-xid might be the right place for this functionality.

cc @SimonSapin

@kwantam
Copy link
Member

kwantam commented Mar 16, 2016

@erickt thanks for raising this issue!

@SimonSapin my vote would be to insert this table in xid for now, and then when we eventually get around to making an ur--Unicode crate with all the tables, we can relocate it there.

The reason to put it in xid is that, roughly speaking, xid and pattern_white_space predicates are often both used in parsing, thus xid is a better match than any of the other existing crates; and I don't think it's necessary or productive to create an entirely new crate for pattern_white_space.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants