Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'unicode.py' is messy #8

Open
popzxc opened this issue Jun 27, 2021 · 2 comments
Open

'unicode.py' is messy #8

popzxc opened this issue Jun 27, 2021 · 2 comments

Comments

@popzxc
Copy link
Contributor

popzxc commented Jun 27, 2021

Currently, unicode.py is written in the out-of-date style of Python and is, honestly, hard to work with.

I am more than willing to refactor and rewrite it in the modern Python3 with enforced type checks (without making it too fancy and "pythonic" though; I understand that it's not the Python repo), but not sure whether it will be welcome.

Will it?

@Manishearth
Copy link
Member

Hmm, so part of the thing is that all (most) of the rust unicode crates use some shared python code for this and being consistent cross crate is very useful. So I'm open to having some stuff be refactored but ideally it's done across the unicode-rs org which is a bigger task.

@Manishearth
Copy link
Member

I think it's worth making the PR, this crate is the most up to date when it comes to the python, and maybe we can file followups on the other crates to copy the style here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants