Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inflection of adjectives #13

Open
grhoten opened this issue Mar 14, 2024 · 3 comments
Open

Support inflection of adjectives #13

grhoten opened this issue Mar 14, 2024 · 3 comments
Labels
discuss Discussion item

Comments

@grhoten
Copy link
Member

grhoten commented Mar 14, 2024

We should be able to inflect adjectives. In English, this isn't as big of an issue. For a lot of other languages, adjectives inflect based on the grammatical number and grammatical gender of the noun being referenced.

For example, in Spanish, if I were to describe the color of a red light, I'd say "luz roja", but for lights, I'd say "luces rojas". If I say red book, then I'd say "libro rojo". The adjective typically takes on the grammatical properties of the noun being described.

@grhoten grhoten added the discuss Discussion item label Mar 14, 2024
@nciric
Copy link
Contributor

nciric commented Mar 15, 2024

+1 as an important case. I would put it at the same or slightly lower priority than nouns #19 .

I know we are solving for a general message formatting solution, but I wonder how we plan to use this in MF2.0. Would adjective(s) and a noun be one placeholder or separate, with the need to link them somehow? This also relates to the ordering of adjectives #14 . @mihnita @macchiati

Lower level question is - would our API get the whole set (adjectives and the noun) and try to sort it out, or do we expect that caller calls our code for each word (separately, with necessary grammatical information)? This is tangential to the original question. We can discuss this point in #3 .

@grhoten
Copy link
Member Author

grhoten commented Mar 15, 2024

That’s a good discussion point. Can you start a separate issue for that?

@nciric
Copy link
Contributor

nciric commented Mar 16, 2024

That’s a good discussion point. Can you start a separate issue for that?

Edited post and pointed to issue #3 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Discussion item
Projects
Status: In Progress
Development

No branches or pull requests

2 participants