Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining ICU4X FFI to accept potentially ill-formed UTF-8 #4853

Open
sffc opened this issue Apr 30, 2024 · 1 comment · May be fixed by #4923
Open

Migrate remaining ICU4X FFI to accept potentially ill-formed UTF-8 #4853

sffc opened this issue Apr 30, 2024 · 1 comment · May be fixed by #4923
Assignees
@younies
Labels
A-ffi Area: FFI, WebAssembly, Transpilation
Milestone
ICU4X 2.0

Comments

@sffc
Copy link
Member

sffc commented Apr 30, 2024

For the general Diplomat discussion: rust-diplomat/diplomat#471

In ICU4X: we need to decide on unicode_bidi behavior. All remaining &str FFIs need to be migrated to DiploamtStr.
@sffc sffc added the A-ffi Area: FFI, WebAssembly, Transpilation label Apr 30, 2024
@sffc sffc added this to the ICU4X 2.0 milestone Apr 30, 2024
@robertbastian robertbastian mentioned this issue May 6, 2024
Merged
robertbastian added a commit that referenced this issue May 7, 2024
@robertbastian
Replace unsafety in ICU4XBidi::for_text by optional (#4869)
ddae43c 
Part of #4853

This is a breaking change in C++.
@robertbastian
Copy link
Member

@younies over to you for ICU4XMeasureUnitParser::parse_measure_unit

@younies younies linked a pull request May 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@younies younies

Labels
A-ffi Area: FFI, WebAssembly, Transpilation
Projects
None yet
Milestone
ICU4X 2.0
Development

Successfully merging a pull request may close this issue.

Returns Error when the units id is not a valid UTF-8 younies/icu4x
3 participants
@sffc @younies @robertbastian