New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Convertible, Try to implemnt `From<Ratio<BigInt>>` #4847

Open

younies opened this issue Apr 25, 2024 · 0 comments

Assignees

Member

younies commented Apr 25, 2024 •

edited

Aslo, as @Manishearth said

I'm ambivalent on num_traits. I think there is a stronger reason to try that now that the From will be from num types rather than icu4x types.

We can also try that as a followup and land this as is, since Younies was a bit unclear about how the traits would work.

See : #4829 (comment)

younies mentioned this issue

Implement Generic Type for Convertible Entities #4829

Merged

younies self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment