ICU4X 1.3 (Oct 4, 2023) - assets not up to date? #4125
-
|
Hello I get this message when clicking on the tag icu@1.3.2 in the Releases view. In both assets, the file CHANGELOG.md starts with Is there a problem with this release? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 3 replies
-
|
The tagged 1.3.2 is indeed not on the main branch (our only branch), as we had to do some cherry-picks. I don't think that that should be a problem. The changelog only got updated after tagging, so it does not show 1.3 yet, our bad. If you look at the version in the top-level |
Beta Was this translation helpful? Give feedback.
-
|
Can we change the GitHub 1.3 release to instead be on 3670b3c |
Beta Was this translation helpful? Give feedback.
-
|
Releases are on tags, and |
Beta Was this translation helpful? Give feedback.
-
|
In general I am okay with the release tags not containing the updated changelog. But we should probably start crafting the changelog in advance so we can be better about this. |
Beta Was this translation helpful? Give feedback.
The tagged 1.3.2 is indeed not on the main branch (our only branch), as we had to do some cherry-picks. I don't think that that should be a problem.
The changelog only got updated after tagging, so it does not show 1.3 yet, our bad. If you look at the version in the top-level
Cargo.toml, it is 1.3.2.