Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve collation test generation #187

Open
1 of 6 tasks
echeran opened this issue Feb 29, 2024 · 1 comment
Open
1 of 6 tasks

Improve collation test generation #187

echeran opened this issue Feb 29, 2024 · 1 comment

Comments

@echeran
Copy link
Collaborator

echeran commented Feb 29, 2024

  • Rename collation_short to collation (for test_type) - Test type "collation_short" should be renamed to "collation" throughout the project #186
  • For UCA conformance test data, include collation strength IDENTICAL per tuple (according to https://unicode.org/Public/UCA/latest/CollationTest.html)
  • For ICU collation test data (collationtest.txt), should create code to parse file in a top-to-bottom stateful-application-of-settings
    • A less-than relation can have an expected strength (<2). This is currently ignored. It can turn into an additional expectation in the test tuple. In this case, the left string should compare secondary less-than the right string. Compare at strength minus 1 (in this case, primary) where they should be equal. At secondary strength, left < right. This would override the general collator strength, with an additional marker to compare equal at the next-lower strength.
    • For tuples from collation conformance test files, ICU needs the normalization=on setting. (Check the ICU test code.) (For tuples from collationtest.txt, this should only be turned on when the test data says so.)
  • Fix double escaping problems
    • example executor test case input string: {"label":"0001704","s1":"\\u007f!","s2":"\u0080!","line":339,"ignorePunctuation":true} - note the \\u007f
@sven-oly
Copy link
Collaborator

sven-oly commented Mar 1, 2024

PR#188 addressed double escaping for "s1" and "s2" with big improvements in results in most platforms, e.g. NodeJS 74 from 2,244 to 377 test failures, ICU4C 74 from 6,757 to 4,895 failures.

@sffc sffc added this to the Priority ⟨P2⟩ milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants