Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bengali Galatians doesn't show correctly in PDF preview. #7533

Open
birchamp opened this issue Oct 10, 2023 · 7 comments
Open

Bengali Galatians doesn't show correctly in PDF preview. #7533

birchamp opened this issue Oct 10, 2023 · 7 comments
Labels

Comments

@birchamp
Copy link
Contributor

birchamp commented Oct 10, 2023

If you import the attached USFM and choose print preview then the preview shows that chapter 1 beginning at verse 6. The first paragraph marker \p is just before verse 6. Other USFM texts with no paragraph markers work correctly.
49-BN_GAL file

screenshot

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Oct 10, 2023 via email

@birchamp
Copy link
Contributor Author

Thanks @PhotoNomad0 Is it using proskomma already?

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Oct 10, 2023 via email

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Oct 11, 2023

@birchamp @elsylambert - tested with latest release: translationCore 3.5.1 (6e1cd7b). This is looking good here, but then again the example file above does have a \p after chapter 1.

Screenshot 2023-10-11 at 11 57 20 AM

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Oct 11, 2023

@birchamp @elsylambert
OK, I removed the first \p marker and see the bug mentioned.

It looks like last year we made a fix for bibles that did not have any paragraph markers (do not understand proskommas fixation about paragraph markers). Now adding a fix for when there is not a paragraph marker before the first verse.

Do we want to release a minor tCore update with this fix?

@PhotoNomad0
Copy link
Contributor

@elsylambert Fix is in latest develop build translationCore 3.5.2 (9d8cdec)

@elsylambert
Copy link

Looks good in translationCore 3.6.4 (ee24062).

Screenshot 2024-03-21 at 9 01 43 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants