Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Downloading fa tNotes from fa_gl, tCore gets stuck in a loop due to missing resources. #7498

Open
PhotoNomad0 opened this issue May 26, 2023 · 11 comments
Assignees
Labels

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented May 26, 2023

Story Explanation

User Story

When you try to download fa_gl/fa_ta in tc, it gets stuck in a loop trying to download dependency https://git.door43.org/fa_gl/fa_ta/archive/v69.zip which it can't find.

tC should give up and show error if dependent resource does not exist.

Additional data:
Correction - the fa_ta does exist, but the manifest and data are actually tNotes. Still we need to fail more gracefully. @rich Mahn

Features / Specifications

  • [ ]
  • [ ]
  • [ ]

Definition of Done

  • [ ]
  • [ ]
  • [ ]

Additional Context

Mockups

@RUN-Projects
Copy link

It seems to be happy now if all fa resources except for tN are added. It seems to be just tN that it doesn't like (at least on linux).

@RUN-Projects
Copy link

Should this be 2 different issues -- one to sort out fa tN, and the other to add something helpful to the whitescreen (like which resource directory to delete?)?

@elsylambert
Copy link

elsylambert commented Jan 10, 2024

@PhotoNomad0 I was on tC 3.6.2 on Mac and was able to download fa_gl bibles and translationHelps resources. The translationNotes folder contains only this manifest file and no other content.
This is the manifest file:
manifest.json
Log file:
Wed Jan 10 2024.log.zip

This is the link from DCS for ga_tn: https://git.door43.org/fa_gl/fa_tn and not seeing all these tsv files in tC.
Door43 Content Service
fa_tn

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Jan 10, 2024

@elsylambert Looking in the fa_tn manifest.yaml, it shows all the books of the Bible the the projects list: https://git.door43.org/fa_gl/fa_tn/src/branch/master/manifest.yaml . But in the repo itself, only 8 books are present: https://git.door43.org/fa_gl/fa_tn

@PhotoNomad0
Copy link
Contributor Author

In the fa_glt the same issue (https://git.door43.org/fa_gl/fa_glt/src/branch/master/manifest.yaml) shows all the books of the Bible the the projects list, but only 8 books are present in the repo: https://git.door43.org/fa_gl/fa_glt

@PhotoNomad0
Copy link
Contributor Author

@elsylambert I see the same problem with just the manifest in the folder. Trying again after deleting folder.

@PhotoNomad0
Copy link
Contributor Author

@elsylambert @birchamp It looks like the problem is this field in the manifest:

    "relation": [
      "fa/ult",
      "fa/ust",
      "hbo/uhb",
      "el-x-koine/ugnt",
      "fa/ta",
      "fa/tq",
      "fa/tw"
    ],

TN needs to know what version of the original languages where used in making the selections, so it can load that specific version from Door43. It should be something like:

    "relation": [
      "en/ult?v=41",
      "en/ust?v=40",
      "hbo/uhb?v=2.1.30",
      "el-x-koine/ugnt?v=0.30",
      "en/ta?v=33",
      "en/tq?v=38",
      "en/tw?v=36"
    ],

@PhotoNomad0
Copy link
Contributor Author

@elsylambert @birchamp - It looks like the manifest has already been fixed in the master branch (https://git.door43.org/fa_gl/fa_tn/src/branch/master/manifest.yaml). They just need to make a new release with the fix.

@elsylambert
Copy link

@birchamp It looks like the manifest has already been fixed in the master branch (https://git.door43.org/fa_gl/fa_tn/src/branch/master/manifest.yaml). They just need to make a new release with the fix.

@PhotoNomad0
Copy link
Contributor Author

Fix is in translationCore 3.6.3 (e859026)

@PhotoNomad0 PhotoNomad0 self-assigned this Mar 11, 2024
@elsylambert
Copy link

translationCore 3.6.3 (e859026). tC shows error on fa_tn download as in the screenshot:
Screenshot 2024-03-11 at 4 35 41 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants