Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting broken with Ampersand in tNotes original quotes #7490

Open
PhotoNomad0 opened this issue Mar 14, 2023 · 1 comment
Open

Highlighting broken with Ampersand in tNotes original quotes #7490

PhotoNomad0 opened this issue Mar 14, 2023 · 1 comment

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Mar 14, 2023

Story Explanation

User Story

Highlighting broken with Ampersand in tNotes original quotes when there is a verse span.

@abelpz found this while testing a verse range combined with an original language quote that contained an ampersand.

To see this in tCore, download the pre-release of en_ult and en_tn in es-419_lab org. Open a php project in tCore. And for tNotes select the GL of es-419_lab/en_tn. Launch tNotes and look in abstract-nouns. The highlighting is greedy:

Screenshot 2023-03-27 at 6 47 54 AM

Features / Specifications

  • [ ]
  • [ ]
  • [ ]

Definition of Done

  • [ ]
  • [ ]
  • [ ]

Additional Context

Mockups

@PhotoNomad0 PhotoNomad0 self-assigned this Mar 14, 2023
@PhotoNomad0 PhotoNomad0 changed the title Highlighting broken with Ampersand Highlighting broken with Ampersand in tNotes original quotes Mar 14, 2023
@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Mar 27, 2023

@birchamp @elsylambert - The first step here is to do a refactor: #7492. Later we can use the shared code in all the apps so we have consistent highlighting. And then we can fix this greedy highlighting behavior in all apps at the same time.

@PhotoNomad0 PhotoNomad0 removed their assignment Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant