Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percent complete is 99% for tW ru_rlob-2pe_book but it is all checked #7461

Open
birchamp opened this issue Dec 7, 2022 · 11 comments
Open

Comments

@birchamp
Copy link
Contributor

birchamp commented Dec 7, 2022

This project https://git.door43.org/ru_gl/ru_rlob_2pe_tcore_checked_tW-checked_tN-aligned shows 99% complete even though it is entirely checked.

@birchamp
Copy link
Contributor Author

birchamp commented Dec 7, 2022

@elsylambert at some point when you're testing tC can you test this issue?

@elsylambert
Copy link

@birchamp Which tC version are you seeing this?

@elsylambert
Copy link

Tested this project in translationCore 3.4.0 (146a9f1) .
After importing the project, tW shows 99% completion, when no GL was selected. After choosing English-en-D43 catalog as GL, the tools card shows 100% completion.
Screenshot 2022-12-07 at 9 48 36 AM

  • Download ru content, ru_gl, tW resources from content updater.
  • Select ru_gl as GL for tW card, the completion goes down to 99%.

Screenshot 2022-12-07 at 9 48 25 AM

  • Uncheck the "Key words" checkbox, the completion goes to 100%

Screenshot 2022-12-07 at 9 48 16 AM

@elsylambert
Copy link

Note that all the checks in tW are completed. @PhotoNomad0

@PhotoNomad0
Copy link
Contributor

@elsylambert How did you download this app? tCore is throwing an error for me that the url is not valid.

@elsylambert
Copy link

@PhotoNomad0 I did online import using the URL https://git.door43.org/ru_gl/ru_rlob_2pe_tcore_checked_tW-checked_tN-aligned last week.

@PhotoNomad0
Copy link
Contributor

@elsylambert Oops, I'm using QA server!

@PhotoNomad0
Copy link
Contributor

@elsylambert I'm wondering if this is because they have 4 tw checks that are marked as no selection is needed?

@PhotoNomad0
Copy link
Contributor

@elsylambert Yes, making selections for those four checks eventually gets to 100%. Will have to check the algorithm to see if makes use of no checks needed.

@PhotoNomad0
Copy link
Contributor

@elsylambert @birchamp - It looks like there is a check that is failing:

Screenshot 2022-12-12 at 12 07 19 PM

It looks like the groupId should have been "righteous" instead of "righteousness"? Not sure why it is not displayed though.

Here is the check in https://git.door43.org/ru_gl/ru_twl/src/branch/master/twl_2PE.tsv on line186. The path is rc://*/tw/dict/bible/kt/righteousness, but in https://git.door43.org/ru_gl/ru_tw/src/branch/master/bible/kt there is no article righteousness.md, but there is one for righteous.md. It's looking like a bug that tW is not showing the checks when the article is missing. Continuing to look...

@PhotoNomad0
Copy link
Contributor

Notes:

  • see generateMenuData() in ./tc-ui-toolkit/src/GroupedMenu/utils.js - it probably should handle entries from index (groupsIndex) whose id is not in data (groupsData). Or maybe tCore should create categories for check items not defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants