From ee17893ec2d76be5c7c4f5d278e01efb98361fb3 Mon Sep 17 00:00:00 2001 From: Richard Mahn Date: Tue, 29 Aug 2023 10:30:35 -0600 Subject: [PATCH] Fixes issue with Catalog not being populated for repo API object --- models/repo/repo_list.go | 4 ++-- services/convert/repository.go | 2 +- services/convert/repository_dcs.go | 16 +++++----------- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/models/repo/repo_list.go b/models/repo/repo_list.go index 48d4c7958b..71a2aa6b23 100644 --- a/models/repo/repo_list.go +++ b/models/repo/repo_list.go @@ -508,9 +508,9 @@ func SearchRepositoryCondition(opts *SearchRepoOptions) builder.Cond { door43metadata.GetOwnerCond(opts.Owners, false), door43metadata.GetSubjectCond(opts.Subjects, false), door43metadata.GetResourceCond(opts.Resources), - door43metadata.GetContentFormatCond(opts.ContentFormats, true), + door43metadata.GetContentFormatCond(opts.ContentFormats, false), door43metadata.GetBookCond(opts.Books), - door43metadata.GetLanguageCond(opts.Languages, true), + door43metadata.GetLanguageCond(opts.Languages, false), door43metadata.GetMetadataTypeCond(opts.MetadataTypes, false), door43metadata.GetMetadataVersionCond(opts.MetadataVersions, false)) /*** EMD DCS Customizations ***/ diff --git a/services/convert/repository.go b/services/convert/repository.go index 3b2eb5aa0c..d0b1fe75c3 100644 --- a/services/convert/repository.go +++ b/services/convert/repository.go @@ -147,7 +147,7 @@ func innerToRepo(ctx context.Context, repo *repo_model.Repository, mode perm.Acc repoAPIURL := repo.APIURL() - return ToRepoDCS(ctx, repo, isParent, &api.Repository{ + return ToRepoDCS(ctx, repo, &api.Repository{ ID: repo.ID, Owner: ToUserWithAccessMode(ctx, repo.Owner, mode), Name: repo.Name, diff --git a/services/convert/repository_dcs.go b/services/convert/repository_dcs.go index 4ae0b89019..b6ef7c4899 100644 --- a/services/convert/repository_dcs.go +++ b/services/convert/repository_dcs.go @@ -11,13 +11,11 @@ import ( ) // ToRepoDCS adds Door43 metadata properties to the API Repo object -func ToRepoDCS(ctx context.Context, repo *repo_model.Repository, isParent bool, apiRepo *api.Repository) *api.Repository { +func ToRepoDCS(ctx context.Context, repo *repo_model.Repository, apiRepo *api.Repository) *api.Repository { if err := repo.LoadLatestDMs(ctx); err != nil { return apiRepo } - dm := repo.RepoDM - apiRepo.Title = dm.Title apiRepo.Subject = dm.Subject apiRepo.Language = dm.Language @@ -28,14 +26,10 @@ func ToRepoDCS(ctx context.Context, repo *repo_model.Repository, isParent bool, apiRepo.MetadataType = dm.MetadataType apiRepo.MetadataVersion = dm.MetadataVersion apiRepo.Ingredients = dm.Ingredients - - if isParent { - apiRepo.CatalogStages = &api.CatalogStages{ - Production: ToCatalogStage(ctx, repo.LatestProdDM), - PreProduction: ToCatalogStage(ctx, repo.LatestPreprodDM), - Latest: ToCatalogStage(ctx, repo.DefaultBranchDM), - } + apiRepo.CatalogStages = &api.CatalogStages{ + Production: ToCatalogStage(ctx, repo.LatestProdDM), + PreProduction: ToCatalogStage(ctx, repo.LatestPreprodDM), + Latest: ToCatalogStage(ctx, repo.DefaultBranchDM), } - return apiRepo }