Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req.query.accessToken should be a req.headers.authorization check instead on POST #843

Open
kaihendry opened this issue Jul 3, 2019 · 0 comments
Assignees

Comments

@kaihendry
Copy link
Contributor

I was wondering why in https://github.com/unee-t/lambda2sns APIAccessToken was used as get parameters as well as a header -H "Authorization: Bearer XXXXX".

I removed the parameter assuming both ways would work & Iit didn't. I can see now there is no code to check req.headers.authorization in the POST request for example in

So be good to update the code to support Authorization for two reasons:

  • get auth parameters isn't the norm for POST
  • also helps not put credentials in my logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants