Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add CFG Scale and CFG and context free grammars #30

Open
ArEnSc opened this issue Jan 16, 2024 · 7 comments
Open

Need to add CFG Scale and CFG and context free grammars #30

ArEnSc opened this issue Jan 16, 2024 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@ArEnSc
Copy link

ArEnSc commented Jan 16, 2024

No description provided.

@amakropoulos
Copy link
Collaborator

Thanks for the issue!
I think you mean adding the following options from llama.cpp, is it correct?
--grammar / --grammar-file
--cfg-negative-prompt / --cfg-negative-prompt-file
--cfg-scale

If yes, sure I can do that.
I'm trying to think of a good way to add different options from llama.cpp without blowing up the UI.
Maybe I would separate some options that are probably less frequently in a usual chat setting.
and provide a field that the used can add arguments to the llama.cpp server command.
What do you think?

@amakropoulos amakropoulos added the enhancement New feature or request label Jan 16, 2024
@ArEnSc
Copy link
Author

ArEnSc commented Jan 16, 2024

yeah I wonder if this is supported onthe llamafile server, I checked I don't see those last 3 options

@amakropoulos
Copy link
Collaborator

I'm upgrading to llamafile 0.6, that contains those :)

@ArEnSc
Copy link
Author

ArEnSc commented Jan 17, 2024

I'm upgrading to llamafile 0.6, that contains those :)

amazing! =D

@amakropoulos amakropoulos added this to the v1.1.0 milestone Jan 18, 2024
@amakropoulos amakropoulos modified the milestones: v1.1.0, v1.0.5 Jan 28, 2024
@amakropoulos
Copy link
Collaborator

I have released v1.0.5 that allows grammars along with other parameters.
Unfortunately I can't set the negative-prompt and the scale because they are not exposed as arguments from the llama.cpp server :/

@ArEnSc
Copy link
Author

ArEnSc commented Feb 1, 2024

I have released v1.0.5 that allows grammars along with other parameters. Unfortunately I can't set the negative-prompt and the scale because they are not exposed as arguments from the llama.cpp server :/

yeah it was confusing since I saw args code that implied that it was availible from llamafile, I think ill or someone will need to go in there and make the changes to the server and understand how the CFG scale works once my project is off the ground, amazing work though btw! =)
from my understanding CFG scale requires that we run inference twice and the server did drift away from the original PR made and it was never merged

@amakropoulos amakropoulos removed this from the v1.0.5 milestone Feb 2, 2024
@amakropoulos
Copy link
Collaborator

amakropoulos commented Feb 3, 2024

yes exactly, I saw the llamafile args and confused it 🙈

@amakropoulos amakropoulos modified the milestones: v2.1.0, v2.0.0 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants