Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low efficiency of uw.fn.evaluate comparing with the uw.fn.evalf in swarm.advection #168

Open
NengLu opened this issue Mar 7, 2024 · 2 comments

Comments

@NengLu
Copy link

NengLu commented Mar 7, 2024

Here is the case1 with free surface boundary condition from Crameri2012. The swarm particle number is 256 * 64 * 9 = 147456.

In swarm advection, the uw.fn.evaif works for evaluating the velocity field while the uw.fn.evaluate doesn't.

The fn.evaluate may need to be improved.

Ex_Crameri2012Case1_testSwarmAdvection.txt

@lmoresi
Copy link
Member

lmoresi commented Mar 7, 2024

More info please - is this about efficiency or a crash ?

@NengLu
Copy link
Author

NengLu commented Mar 7, 2024

It's more like a crash. It stuck in swarm advection when it used the uw.fn.evaluate
And it runs fine when using fn.evaif ( swarm.advection(V_fn=v.fn, delta_t=dt,evalf=True)).
I have checked the velocity field, it seems all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants