Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advection-diffusion convergence issue #161

Open
bknight1 opened this issue Feb 19, 2024 · 4 comments
Open

Advection-diffusion convergence issue #161

bknight1 opened this issue Feb 19, 2024 · 4 comments

Comments

@bknight1
Copy link
Member

bknight1 commented Feb 19, 2024

With increasing resolution the error is not showing a convergence order:
AdvDiff_HP_convergence

The errors are concentrated at the diffusive boundary:
unknown (T) degree comparison:
Hot_pipe_l1_deg_comparison

diffusivity (D) value comparison:
Hot_pipe_l1_D_comparison

To test any updates, the script to check convergence is found here

@lmoresi
Copy link
Member

lmoresi commented Feb 21, 2024

I had a look at this. I think it is unrealistic to start with a case which has an infinite gradient. I have an example notebook that looks at advection starting from a finite time and looking at the change over time and with advection. I'll upload and you can review.

@bknight1
Copy link
Member Author

Keen to have a look!

@lmoresi
Copy link
Member

lmoresi commented Feb 22, 2024

@bknight1 Take a look at Jupyterbook/Notebooks/Examples-Convection/Ex_AdvectionDiffusion_1dBlock.py.

I'm careful to start from a finite time after the step-function initial condition is applied so that it can be represented reasonably well by the mesh (maybe less so for the simplex example shown). Move it / diffuse it and compare before the analytic solution becomes invalid.

@bknight1
Copy link
Member Author

Makes sense! I'll update the script and see how it performs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants