Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate transformation matrix does not match the naming convention of it's function #152

Open
gthyagi opened this issue Feb 7, 2024 · 0 comments

Comments

@gthyagi
Copy link
Contributor

gthyagi commented Feb 7, 2024

Hi,

mesh.CoordinateSystem.rRotN should gives a matrix to convert coordinates in reference frame (i.e., spherical/Annulus) to native frame (i.e., xyz). However, currently it output a matrix that map N --> r instead of r --> N.

Screenshot 2024-02-07 at 11 37 10 pm

which is

$$ \begin{bmatrix} \cos(\theta) & \sin(\theta) \\\ -\sin(\theta) & \cos(\theta) \\\ \end{bmatrix} $$

But actual matrix should be
Screenshot 2024-02-07 at 11 47 14 pm

Note: By taking transpose will output the right one.

@gthyagi gthyagi changed the title Coordinate transformation matrix in Annulus/Spherical mesh does not match the naming convention of it's function Coordinate transformation matrix does not match the naming convention of it's function Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant