Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style guide / python or petsc4py style #124

Open
lmoresi opened this issue May 4, 2023 · 1 comment
Open

style guide / python or petsc4py style #124

lmoresi opened this issue May 4, 2023 · 1 comment

Comments

@lmoresi
Copy link
Member

lmoresi commented May 4, 2023

We have a real mix of python / C++ styles in different parts of the code. I think it's because we sometimes inherit the style choices from petsc4py which tries to follow PETSc.

In the constitutive models we have a traditional python lower_case_underscore choice for arguments to classes and functions but in most of the solvers we have lowerCaseUpperCase patterns.

Doesn't matter much, but can we choose one or the other ?

L

@lmoresi
Copy link
Member Author

lmoresi commented Feb 21, 2024

@julesghub - what we need is an actual style guide that we can follow.

This should include the use of the black formatter, and should also have python / cython in its sights. See the pure-python/cython branch discussion as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant