Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: After applying Standard selection Phone Link is broken #350

Open
sla-te opened this issue Apr 27, 2024 · 8 comments
Open

[BUG]: After applying Standard selection Phone Link is broken #350

sla-te opened this issue Apr 27, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@sla-te
Copy link

sla-te commented Apr 27, 2024

Description

After applying Standard selection Phone Link is broken (and even reverting "All"), does not fix it back.
I can confirm it did work before. Specifically what does not work is the feature, that you can accept and make
calls via Phone Link on Windows (Messages and Apps still work).

OS

Windows 11 Version 22H2 (OS Build 22621.3447)

Reproduction steps

  1. Setup Phone Link on a clean Windows 11 and assert, that you can use the "Calls" feature.
  2. Apply the Standard set of scripts and reboot. Confirm that the Calls feature does not work anymore.
  3. Revert the Standard (or All) selection, reboot and confirm that the Calls feature still does not work.

Screenshots

image

Additional information

Worth to mention, that I first had problems getting it to work, having applied the standard settings of ShutUp10. After applying the "Undo all changes" action and a reboot, it worked perfectly (I also already tried running that again hoping it would revert the changes made by privacy.sexy but it didn't help). So my guess is that anything privacy.sexy does is somewhat not revertible and causes the breakage. Any hints regarding how to provide detailed error information when running Phone Link to pinpoint the root cause is highly appreciated because I kind of enjoyed using this feature.

I also already tried running the script provided by #315 (comment) but it also didn't fix it.

@sla-te sla-te added the bug Something isn't working label Apr 27, 2024
@undergroundwires
Copy link
Owner

Hi @sla-te, if I understand this correctly, you already reverted whole Standard selection but it still fails?

You can try reverting "Disable app access to Bluetooth devices".

@sla-te
Copy link
Author

sla-te commented Apr 27, 2024

@undergroundwires Thank you for hinting on this one and I tried but it didn't fix it.

Yes, correct I tried reverting the whole Standard selection and additionally I also tried reverting the "All" selection, despite I never actually applied it, hoping it would fix it :).

@undergroundwires
Copy link
Owner

As you already reverted "Standard", this should have been caused by privacy.sexy but another software/configuration/hardware issue. Irreversible scripts are just cleanup scripts that would have no impact on what you're experiencing. You need to restart after reverting "Standard" as you already did it.

Reverting "All" should be safe. It can restore other settings set by other apps.

If you find out the reason (if there was a bug with reversion process), please inform back so we can fix it.

@sla-te
Copy link
Author

sla-te commented Apr 27, 2024

Well, I wouldn't have opened the ticket without having tried everything I could think of. I can though confirm that it did work before running privacy.sexy (and I encourage you to reproduce it on by using my reproduction steps, I am certain, that it will work).

Would appreciate if you could provide me suggestions on how I could find out what is causing it. Also from what I can tell there are quite some selections, where you cannot select "revert" for.

image
image
(and there is more)

@undergroundwires
Copy link
Owner

It's hard to reproduce for me but someone else in the community can help. I do not have physical access to a Windows machine with Bluetooth access.

You're right, these scripts should all have revert codes as they're pretty straightforward to restore. I have some work on local branches that I haven't pushed yet, so my last comment is incorrect for the latest released version.

If you're confident that this is caused by privacy.sexy, the best troubleshooting way, going through all recommend: standard that does not have revert logic, and restore those. I'm adding revert codes slowly to the ones missing but it takes a lot of time while I have some other priorities. I'd merge a PR for it. The file to look at to find the diff: windows.yaml.

I think deleting HKLM\Software\Policies\Microsoft registry subtree completely would revert most of these (but not all). On default OS state these keys do not exist, so it's safe to execute.

If we figure out this script, I'll document it remove it from Standard right away.

@sla-te
Copy link
Author

sla-te commented Apr 27, 2024

Alright, was hoping there might be an easier way, ill do my best to go through all of them then hehe

@sla-te
Copy link
Author

sla-te commented Apr 29, 2024

@undergroundwires I found it x)

Open command prompt as admin:

Type> gpedit

Computer Configuration>Administrative Templates>Windows Components>App Privacy

Enable: Let Windows apps make phone calls

Close gpedit

In the same command prompt as admin:

Type> regedit

Goto>Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Windows\AppPrivacy

Set LetAppsAccessPhone to "1"

Close regedit

Close Command Prompt.

Lastly make sure you computer and your phone are on the same WIFI.

Reboot and test.

ref.: https://techcommunity.microsoft.com/t5/windows-insider-program/phone-link-says-i-already-have-the-phone-set-up-with-another-app/m-p/3749827

@undergroundwires
Copy link
Owner

Thank you @sla-te for the information. I'll document all of the "Disable app access" scripts. Document that this script breaks Phone Link in the title and move it to Strict pool. Hopefully all Standard scripts will be documented, reversible and non-breaking meanwhile still being as aggressive as possible regarding protecting privacy.

undergroundwires added a commit that referenced this issue May 24, 2024
This commit adjusts the recommendation level for scripts that disable
UWP app access to accommodate user issues #121, #339, #350. It also
extends their documentation to reflect the new changes and with
cautions.

Changes:

- Add caution text for all scripts about potential impacts.
- Move disabling app access to notifications from 'Standard' to
  'Strict'. This addresses #121 and #339, where users report lack of
  notification as unintended side-effects.
- Move disabling app access to phone calls from 'Standard' to 'Strict'.
  This addresses #350 where its effect on the Phone Link app was
  reported as an unintended side-effect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants