Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search options to include/exclude fields #340

Open
Drovosek01 opened this issue Apr 12, 2024 · 6 comments
Open

Add search options to include/exclude fields #340

Drovosek01 opened this issue Apr 12, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Drovosek01
Copy link

I just open https://privacy.sexy/ and write "defender" word for looks functions relatend to Windows Defender but:

Search result have not only points related to Windows Defender

image

@Drovosek01 Drovosek01 added the bug Something isn't working label Apr 12, 2024
@undergroundwires
Copy link
Owner

Hi @Drovosek01, since 0.13.0, the search also includes the documentation. So I'd say it's a designed feature rather than a bug. But the search can be more clear with what are the actual matches. Check the docs for those stuff and you'll see why it's matching.

Maybe if the search match is within the documentation, the documentation (i) icon on right, should be toggled on by default. We should then also highlight the matched keywords so it's visible why the search is showing those.

What do you think?

@Drovosek01
Copy link
Author

Hi @Drovosek01, since 0.13.0, the search also includes the documentation. So I'd say it's a designed feature rather than a bug. But the search can be more clear with what are the actual matches. Check the docs for those stuff and you'll see why it's matching.

Maybe if the search match is within the documentation, the documentation (i) icon on right, should be toggled on by default. We should then also highlight the matched keywords so it's visible why the search is showing those.

What do you think?

Aww... thanks for the advice. I didn't know about it, so I thought it was a bug.

I think it would be convenient if there were settings in the search.

For example, the toggle switch "Search only in headings (item names)" would solve this issue.

@undergroundwires undergroundwires added enhancement New feature or request and removed bug Something isn't working labels Apr 16, 2024
@undergroundwires undergroundwires changed the title [BUG]: Search for "defender" show not only defender points Add search options to include/exclude fields Apr 16, 2024
@undergroundwires
Copy link
Owner

It makes sense.

To refine the UI: Where should we have the search options? An icon somewhere? And where should it be placed? And when should be visible (when user starts typing/searching or before) 🤔.

The goal is to keep the UI minimal, and as clean as possible when adding features.

@plantindesk
Copy link

plantindesk commented Apr 27, 2024

It makes sense.

To refine the UI: Where should we have the search options? An icon somewhere? And where should it be placed? And when should be visible (when user starts typing/searching or before) 🤔.

The goal is to keep the UI minimal, and as clean as possible when adding features.

What having a firfox like feature

For eg to search only DuckDuckGo we use @duckduckgo in firefox

@undergroundwires
Copy link
Owner

@plantindesk can you elaborate? I did not understand.

Off-topic: I do recommend against DuckDuckGo. They're deliberately blocking privacy.sexy webpage and GitHub page. Too much censoring, pressuring free speech with their political bias manipulating the results. A lot of sketchy stuff for a website that claims to be privacy friendly, becoming a privacy parody itself.

@plantindesk
Copy link

plantindesk commented Apr 28, 2024

@plantindesk can you elaborate? I did not understand.

Off-topic: I do recommend against DuckDuckGo. They're deliberately blocking privacy.sexy webpage and GitHub page. Too much censoring, pressuring free speech with their political bias manipulating the results. A lot of sketchy stuff for a website that claims to be privacy friendly, becoming a privacy parody itself.

We also use is: to filter open and close issues in github

image
image

I mean like this also pls come at #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants