Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opsz bug in Firefox #208

Open
guidoferreyra opened this issue Jun 5, 2020 · 8 comments
Open

Opsz bug in Firefox #208

guidoferreyra opened this issue Jun 5, 2020 · 8 comments

Comments

@guidoferreyra
Copy link

guidoferreyra commented Jun 5, 2020

Hi!
I’ve found an odd issue when setting Fraunces to the max value for opsz and a font size greater than 256px. When these conditions are matched It doesn‘t renders the correct font variation.
In the screenshot below you can see two lines.
Both uses the same font variation settings but different font files. The top line uses the current font files from the "fonts" folder of this repo and the bottom line, that is working as expected, uses a font file from the Fraunces Minisite.

Captura de Pantalla 2020-06-05 a la(s) 13 46 09
From Left to Right: Chrome, Safari, Firefox.

Probably it‘s a FF bug but I couldn’t reproduce this error with other fonts that has opsz too.
Here I attach the test html so you can see this by yourselves.

FrauncesTestCase.zip

Best.

@davelab6
Copy link
Contributor

I can reproduce this in Firefox stable, but not in Firefox Nightly:

Screen Shot 2020-08-13 at 5 14 36 PM

Screen Shot 2020-08-13 at 5 15 05 PM

I am curious why this is happening, though. I guess a careful comparison of an opsz font that does not do this using a tool like https://github.com/googlefonts/fontdiffenator or https://github.com/source-foundry/fdiff or OTMaster could uncover what is happening...

@davelab6
Copy link
Contributor

davelab6 commented Sep 8, 2020

This seems to happen only in Fraunces, so I would like this to be debugged and fixed by Viviana or someone else :)

@guidoferreyra
Copy link
Author

Hi! I have a possible solution that seems to fix this issue but I didn‘t tested if it cause something unwanted in other areas. I can make a PR later if no one is already working on this.

@davelab6
Copy link
Contributor

davelab6 commented Sep 9, 2020

PR would be great, or just an explanation :)

@guidoferreyra
Copy link
Author

I changed the default value for opsz to match the min value and rebuilt the fonts.

@davelab6
Copy link
Contributor

I'm curious what the TTX diff is for the fvar table, eg

ttx -t fvar old.ttf;
ttx -t fvar new.ttf;
diff old.ttx new.ttx;

@guidoferreyra
Copy link
Author

guidoferreyra commented Sep 11, 2020

That was exactly what I’ve done to know why the minisite version was working fine.
Between the version I modified and the one from the repo the only difference is that. And some comments in the named insntances.

11c11
<       <DefaultValue>144.0</DefaultValue>
---
>       <DefaultValue>9.0</DefaultValue>
478c478
<     <!-- 144pt S100 Thin -->
---
>     <!-- Thin -->
487c487
<     <!-- 144pt S100 Light -->
---
>     <!-- Light -->
496c496
<     <!-- 144pt S100 Regular -->
---
>     <!-- Regular -->
505c505
<     <!-- 144pt S100 SemiBold -->
---
>     <!-- SemiBold -->
514c514
<     <!-- 144pt S100 Bold -->
---
>     <!-- Bold -->
523c523
<     <!-- 144pt S100 Black -->
---
>     <!-- Black -->

@vv-monsalve
Copy link
Contributor

I changed the default value for opsz to match the min value and rebuilt the fonts.

Thanks, Guido. It was solved here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants