Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register as buffer Gaussian ratio estimator parameters #146

Open
NoemiAM opened this issue Oct 5, 2023 · 0 comments
Open

Register as buffer Gaussian ratio estimator parameters #146

NoemiAM opened this issue Oct 5, 2023 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@NoemiAM
Copy link
Collaborator

NoemiAM commented Oct 5, 2023

Issue: mean and cov of LogRatioEstimator_Gaussian (here) are not networks parameters, hence they do not get saved in checkpoints and they cannot be loaded back.

Proposed solution: register them as buffers

Relevant: there's no PyTorch functionality for loading checkpoints with buffers of unknown size, e.g. where the buffer size is set during model training (see this issue for a relevant discussion).

@NoemiAM NoemiAM added bug Something isn't working enhancement New feature or request labels Oct 5, 2023
@NoemiAM NoemiAM removed the bug Something isn't working label Oct 5, 2023
@cweniger cweniger added the bug Something isn't working label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants