Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate GEDA and Gaussian Autoregressive models #140

Open
cweniger opened this issue Aug 6, 2023 · 1 comment
Open

Integrate GEDA and Gaussian Autoregressive models #140

cweniger opened this issue Aug 6, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@cweniger
Copy link
Member

cweniger commented Aug 6, 2023

In order to make that happen, we need to consolidate the Gaussian_Autoregressive interface. What about dropping the _X, and only keeping the module-based version? We can later add functionality to default to linear modules for L and Phi. Having two different versions of essentially the same function is probably not the best idea.

@NoemiAM, @FloList , any thoughts about this?

@cweniger cweniger added the enhancement New feature or request label Aug 6, 2023
@NoemiAM
Copy link
Collaborator

NoemiAM commented Aug 15, 2023

@cweniger I agree we should drop one of the two since they are basically the same. But the consolidated version should contain both sampling methods: standard Cholesky decomposition and GEDA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants