Feat/plot cleanup #138
Merged
Feat/plot cleanup #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New names - plot_corner - plot_pair - plot_posteriors (much more polished) Fixed 1d contour levels plotting bug
- plot_pair is again plot_2d (plot_pair should refer to some kind of corner plot, see arviz)
NoemiAM
approved these changes
Sep 4, 2023
Conflicts: notebooks/0A - SwyftModule.ipynb
NoemiAM
approved these changes
Sep 4, 2023
|
Before merging, I want to (re-)add the functionality to histogram the prior samples and smooth those before applying the likelihoods. That strategy should give proper posterior plots with far less samples, in particular for 2-dim posteriors, but will only work for 1-dim and 2-dim marginals. The codes are already there, but currently not used. |
- Removed training data from SwyftDataModule (the current implementation mixed training and test data over multipel rounds)
cweniger
added a commit
that referenced
this pull request
Sep 15, 2023
* Feat/better defaults (#142) Updates: * Modularisation of SwyftModule * Restructuring of `configure_optimizers` and `configure_callbacks` * New default is AdamW with early stopping * Alternatives with AdamW and OneCycleLR and ReduceLROnPlateau exist as well * Automatic reloading of best model at the end of training is default * Feat/plot cleanup (#138) Updates: * Remove plot2. * Extended options * Add `smooth_prior` flag for interpolating likelihoods * Renaming of plotting routines (plot_posterior, plot_corner, plot_pair) * Update example notebook --------- Co-authored-by: NoemiAM <noemi.anaumontel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137 .