Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pytorch-lightning 2.0.0 #119

Open
cweniger opened this issue Mar 24, 2023 · 3 comments
Open

Add support for pytorch-lightning 2.0.0 #119

cweniger opened this issue Mar 24, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cweniger
Copy link
Member

cweniger commented Mar 24, 2023 •
edited

Currently Swyft crashes with PL 2.0.0. Swyft should be updated without breaking backward compatibility with PL 1.9.0 and earlier.
@cweniger cweniger added enhancement New feature or request help wanted Extra attention is needed labels Mar 24, 2023
@cweniger cweniger changed the title Support pytorch-lightning 2.0.0 Add support for pytorch-lightning 2.0.0 Mar 24, 2023
@cweniger cweniger mentioned this issue Apr 28, 2023
Merged
@cweniger
Copy link
Member Author

cweniger commented May 3, 2023

Even after the above merge there are issues when running "infer" with lightning 2.0.0, because of some incomplete limitations of the CombinedLoader in 2.0.0. This probably will solve itself over time as 2.x.x becomes more stable. For now the recommendation will be to stick to 1.9.x.

@cweniger
Copy link
Member Author

cweniger commented Sep 4, 2023

Recent discussions in pl here:

But it still looks like it will not solve all problems (predict loop is not touched).

@cweniger
Copy link
Member Author

cweniger commented Sep 4, 2023

Solution strategy: Write custom CombinedLoader within swyft. Might also be useful for #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cweniger