Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 14 #3

Open
bentzibentz opened this issue Aug 31, 2022 · 1 comment
Open

Angular 14 #3

bentzibentz opened this issue Aug 31, 2022 · 1 comment

Comments

@bentzibentz
Copy link

First of all thanks for that little package.

Is it possible to upgrade your package to support angular v14?

At this time i get an error if i want to upgrade my projects dependencies:

Could not resolve dependency: npm ERR! peer @angular/common@"^13.2.0" from @ultimate/ngx-fullscreen@0.0.5 npm ERR! node_modules/@ultimate/ngx-fullscreen npm ERR! @ultimate/ngx-fullscreen@"^0.0.5" from the root project

The package works fine with v14 but the peer dependency errors are a bit annoying.
@bentzibentz
Copy link
Author

I created a pull request #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bentzibentz