Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Check Report - Shallow crawl check needs re-implementing #6

Open
ldbiz opened this issue Aug 25, 2020 · 1 comment
Open

QA Check Report - Shallow crawl check needs re-implementing #6

ldbiz opened this issue Aug 25, 2020 · 1 comment
Assignees
Labels
QA Check Report Issue relates to the QA Check Report identifying potential w3act issues introduced by users

Comments

@ldbiz
Copy link
Contributor

ldbiz commented Aug 25, 2020

The shallow crawl check was removed temporarily as it was causing the report to fall over.

I think this is probably because there was no data in the test dataset (the test database appears to be several months out of date). However as the function is quite gnarly (pandas/lambda/apply), I've just commented it out so we can get the report running generally, this is a non-core check.

@ldbiz ldbiz self-assigned this Aug 25, 2020
@ldbiz ldbiz added the QA Check Report Issue relates to the QA Check Report identifying potential w3act issues introduced by users label Aug 26, 2020
@ldbiz
Copy link
Contributor Author

ldbiz commented Aug 26, 2020

To reproduce:

Reinstate the function.
Use an out of date db dump (for null results).
Run the full report (-f) with lookback days that end since the db end date.

NB. Assuming that reproduces it, the empty set may be the cause, or it may just be one case - that needs to be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Check Report Issue relates to the QA Check Report identifying potential w3act issues introduced by users
Projects
None yet
Development

No branches or pull requests

1 participant