Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherited OA status does not match W3ACT due to lack of canonicalisation #38

Open
anjackson opened this issue Jun 23, 2023 · 0 comments
Labels

Comments

@anjackson
Copy link
Contributor

anjackson commented Jun 23, 2023

The inherited licenses via python-w3act do not match those determined by W3ACT, because the URL prefix checks are on 'raw' URLs rather than being canonicalised at all. Hence, we have a target 3109 with a https host URL, and a child target 116215 that has a http scheme. Therefore, the host-level check (see also #37) does not match.

(Raised by @crarugal)

The inheritance logic in W3ACT should be checked and reproduced in this code base, ideally using https://github.com/iipc/urlcanon

@anjackson anjackson added the bug label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant