Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests misusing assertTrue for comparisons #1837

Open
code-review-doctor opened this issue Feb 15, 2022 · 0 comments
Open

Some tests misusing assertTrue for comparisons #1837

code-review-doctor opened this issue Feb 15, 2022 · 0 comments

Comments

@code-review-doctor
Copy link

assertTrue is not for comparing arguments, should use assertEqual for that.

The developer's intent of the test was to compare argument 1 with argument 2, which is not happening. Really what is happening is the test is passing because first argument is truthy. The correct method to use is assertEqual. more details

https://github.com/uktrade/data-workspace/blob/1afe282ac34f7adeaf6558d65e1bb3e37c857acc/dataworkspace/dataworkspace/tests/test_admin.py#L2112

I found this issue automatically, see other issues here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant