Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate push and PR jobs in CI #3159

Open
jonmaddock opened this issue Apr 24, 2024 · 1 comment
Open

Remove duplicate push and PR jobs in CI #3159

jonmaddock opened this issue Apr 24, 2024 · 1 comment
Assignees

Comments

@jonmaddock
Copy link
Contributor

When pushing to branch with an associated PR, all jobs are duplicated for the push and pull_request events. Could we just run each job once?

@timothy-nunn
Copy link
Contributor

Hi @jonmaddock,

I believe these jobs have a place in our CI. The PR jobs run the code in the state it will be post-merge (if the PR was merged into main this second). As such we have cases as follow:

image

Where the PR jobs fail (in this case, its because main is currently failing due to #3204). In my opinion, this is another tool to help us identify changes made since the 'branch off' of main that will interact with a feature branch to cause PROCESS to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants