Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement time keeping, avoid lazily deleting expired keys #2

Open
ujjwal-kr opened this issue Mar 2, 2023 · 2 comments
Open

Implement time keeping, avoid lazily deleting expired keys #2

ujjwal-kr opened this issue Mar 2, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ujjwal-kr
Copy link
Owner

Need to make some cycles which checks from another thread for expired keys more like garbage collection for the database.
Cannot afford to delete keys at random times because the e2e will fail, so the cycle needs to be ran after each millisecond?
Too much CPU usage.

@ujjwal-kr ujjwal-kr added the enhancement New feature or request label Mar 2, 2023
@ujjwal-kr ujjwal-kr self-assigned this Mar 2, 2023
@ujjwal-kr
Copy link
Owner Author

ujjwal-kr commented Mar 3, 2023

implemented expire on GET

@ujjwal-kr
Copy link
Owner Author

solution is to lazily expire keys but also keep a thread running to check the db for expired keys after a significant amount of time

@ujjwal-kr ujjwal-kr reopened this Mar 3, 2023
Repository owner deleted a comment from freshy969 Feb 20, 2024
Repository owner deleted a comment from Ikpong-Joseph Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants
@ujjwal-kr and others