Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep colors while changing packages #159

Open
Dimava opened this issue Sep 17, 2022 · 3 comments · May be fixed by #184
Open

Keep colors while changing packages #159

Dimava opened this issue Sep 17, 2022 · 3 comments · May be fixed by #184

Comments

@Dimava
Copy link

Dimava commented Sep 17, 2022

While I'm changing compared packages, package colors keep changing constantly

Some random package was blue.
Added Vue, Vue is blue. Random package is now random color.
Added React, boom, Vue is not blue anymore

What I want is for packages to keep their current color while you are editing - if Vue was blue at some point, it should be kept blue until I remove it, add some another package that takes over blue color, and add it back

Also some more common tools may have preferred colors
Green for Vue, blue for Typescript
Generally if the package has an icon it's the icon color (or favicon color for packages with own website)
@benadam11
Copy link
Collaborator

This is not an ideal experience. We will fix this, but just a warning it might be a few months before we get to it.

@davext
Copy link

davext commented Mar 4, 2023

Please for the love of god

@mfp22
Copy link

mfp22 commented Jul 9, 2023

I have a better idea: Allow people to define colors for libraries that stick permanently. Does anyone want to view React as any color than blue? Angular as not red? This is would be neat to make automatic, but I'm sure it's a technical challenge. But I would like this to exist for small packages too. And if colors are similar, automatically make one dotted or something. This would be ideal imo.

abizek added a commit to abizek/npm-trends that referenced this issue Mar 29, 2024
@abizek
fix: keep colors while changing packages
fc27ea4 
use a record to store package names -> color mapping
add the color to use for a package in its data and use it in all components
fixes uidotdev#159
@abizek abizek linked a pull request Mar 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Keep colors while changing packages abizek/npm-trends
4 participants
@benadam11 @mfp22 @davext @Dimava