Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectMulti improve support for non-scalar lists #214

Open
elbakerino opened this issue Dec 17, 2022 · 0 comments
Open

SelectMulti improve support for non-scalar lists #214

elbakerino opened this issue Dec 17, 2022 · 0 comments
Labels
material-ui About the material-ui design-system use-case Questions regarding a use-case and possible examples for others widget
Projects

Comments

@elbakerino
Copy link
Member

Currently the @ui-schema/ds-material package widget SelectMulti only supports selecting scalar values correctly.

But also e.g. objects would be valid for enum.const/enum.

  • if items.type is set, this should influence the widget logic, if not given it should asume scalar values
  • if scalar, it should behave like currently and sort the selected list on change
  • if non-scalar
    • there must be additional matching added for "getting from selected value back to oneOf/enum values"
    • pure equality checks wouldn't be good for DX/interop, as e.g. properties would need to be on same place for some and not for other devs
    • typings/docs need adjustments
@elbakerino elbakerino added material-ui About the material-ui design-system widget use-case Questions regarding a use-case and possible examples for others labels Dec 17, 2022
@elbakerino elbakerino added this to To do in ui-schema via automation Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
material-ui About the material-ui design-system use-case Questions regarding a use-case and possible examples for others widget
Projects
ui-schema
  
To do
Development

No branches or pull requests

1 participant