-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Core JSON-Schema specific logic into modular packages #100
Labels
enhancement
New feature or request
json-schema-spec
Relates to official JSON-Schema Spec.
refactoring
validators
Projects
Milestone
Comments
elbakerino
added
enhancement
New feature or request
json-schema-spec
Relates to official JSON-Schema Spec.
refactoring
labels
Mar 25, 2021
elbakerino
changed the title
Refactor validators into own package
Refactor schema handling fns into own package
Mar 27, 2021
This was referenced Jun 28, 2021
elbakerino
added a commit
that referenced
this issue
May 4, 2022
- deprecated `UIProvider`, `UIGenerator`, `UIRootRenderer`/`widgets.RootRenderer`, the `ownKey` prop - new `injectPluginStack` util as `UIRootRenderer` replacement - new `GridContainer` in `ds-material` + `ds-bootstrap` for `injectPluginStack` - now `applyPluginStack` applies `memo` internally - fix from `0.4.0-alpha.0`: `Divider` between `GenericListItem` had missing gutters - `material-code` hard-copy react-codemirror2 for React v17
elbakerino
added a commit
that referenced
this issue
May 5, 2022
- mui NumberSlider label had an now invalid color value, also for multiple-numbers sliders, the thumb was incompatible - 0.4.0-alpha typing optimizes
elbakerino
added a commit
that referenced
this issue
Jul 13, 2022
and a few related renamings to make it more clearer
elbakerino
changed the title
Refactor schema handling fns into own package
Refactor Core JSON-Schema specific logic into modular packages
Jul 13, 2022
elbakerino
added a commit
that referenced
this issue
Jul 14, 2022
elbakerino
added a commit
that referenced
this issue
Jul 14, 2022
most likely requires now adjustments for JSDom/React testing
elbakerino
added a commit
that referenced
this issue
Sep 3, 2022
elbakerino
added a commit
that referenced
this issue
Sep 4, 2022
elbakerino
added a commit
that referenced
this issue
Sep 4, 2022
elbakerino
added a commit
that referenced
this issue
Sep 5, 2022
elbakerino
added a commit
that referenced
this issue
Sep 5, 2022
tests still not running for all files (esm, node, react) with new ts-jest setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
json-schema-spec
Relates to official JSON-Schema Spec.
refactoring
validators
Refactor
validators and schema handlerscore into new modular packages, primary for validators. To support further implementations,this will also split react-core from json-schema specific react logic.full
for backend, no-render endless nested validationlevel
for e.g. react frontends, to only validate one-schema levelif
/else
validation throughfull
type
schemas (already full support)validateSchema
automaticallyschema
to all validatorsPart of:
,validators
pluginSimpleStack
schemaPlugins
and,ValidatorStack
PluginStack
WidgetEngine
/WidgetPlugin
/SchemaPlugin
to support version changing, full support for non-render related validations (e.g. validation with a react hook).Ideas
Currently intended changes.
Removement of deprecated logic #192
Package Structure
@ui-schema/system
for general interfacing & typings, JSON-Schema plugins, validators@ui-schema/json-pointer
JSON-Schema pointer@ui-schema/react
for store, provider, pluginstack (exec. part), translate, JSON-Schema react renderers, react plugins@ui-schema/immutable
for all immutable tools (or extract/include as other micropackage?) [would be the first "core depencies" then]@ui-schema/ui-schema
will be removed most likelyNaming Structure
PluginStack
to something likeWidgetEngine
PluginStack
/PluginSimpleStack
/PluginType
/PluginSimple
...PluginStack
>WidgetEngine
andWidgetPlugin
PluginSimpleStack
>SchemaPluginStack
andSchemaPlugin
UI*
prefixes optimize, only for the most important domains:Meta
,Store*
storeUpdater
andstoreActionHandler
factory partsWidgetPayload
, whereWidgetProps
is the react-specific implementationJSON-Lib
validate
callback / interfacingparse
schema" part, which could consume the specifiedvalidate
isRootSchema
/mergeSchema
(buildHappyPath
)Tactic-UI
widgetsBinding
subkeystypes
/custom
will be merged into onewidgetsBinding
custom components (e.g.GroupRenderer
will move to a new definition mapUIMeta*
will be just an adjustedtactic-ui
context bindingUpdates
2022-11
As
WidgetEngine
/PluginStack
and the generalwidgetsBinding
are too coupled to be able to cleanly rewrite it, a new package was created which will replace those internals in0.5.0
: @tactic-ui/react.This will replace and ease a lot of open typing issues, e.g. plugins requirements are automatically collected when adding plugins.
UIS will rewire tactic-ui to provide a similiar setup like currently, as tactic-ui itself doens't bring any UI or data-specific logic.
2023-09-29
Dropped extra json-schema packages, was planned to also split up, now only separated by "react vs. universal js".
The text was updated successfully, but these errors were encountered: