Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neural Monkey should throw Exception when tf.Saver.restore fails #821

Open
varisd opened this issue May 7, 2019 · 0 comments
Open

Neural Monkey should throw Exception when tf.Saver.restore fails #821

varisd opened this issue May 7, 2019 · 0 comments
Labels

Comments

@varisd
Copy link
Member

varisd commented May 7, 2019

Try-catch block at
https://github.com/ufal/neuralmonkey/blob/master/neuralmonkey/learning_utils.py#L250

Print a warning, when tf.Saver.restore while ignoring the caught exception. This leads to a confusing behavior where user might think that the variables present in the checkpoint were correctly loaded. This is not true, since the variable loading is halted when the exception is thrown.

@varisd varisd added the bug label May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant