Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset series should support max_len (max_size) flag. #817

Open
varisd opened this issue Apr 26, 2019 · 0 comments
Open

Dataset series should support max_len (max_size) flag. #817

varisd opened this issue Apr 26, 2019 · 0 comments

Comments

@varisd
Copy link
Member

varisd commented Apr 26, 2019

This is motivated by fact that for training stability, you can choose bucketed batching with batch_size specified in the number of tokens per batch.

This can create batches with small number of very long examples which can, however, be later truncated (e.g. in Sequence, Labeler, etc.) by a max_len flag. This will effectively reduce the size of such batch, possibly messing the training process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant