Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreedyRunner should not fetch training-related tensors by default during inference #804

Open
varisd opened this issue Mar 15, 2019 · 4 comments
Labels

Comments

@varisd
Copy link
Member

varisd commented Mar 15, 2019

Currently, the train_xent, runtime_xent is default fetch in the GreedyRunner. Computation of these requires references, which might not be available during inference time (e.g. we only want to produce output and not compute xents).

This can be sort-of avoided by listing input data also as the reference. However, this may not be completely intuitive to the user.

@varisd varisd added the bug label Mar 15, 2019
@jlibovicky
Copy link
Contributor

jlibovicky commented Mar 18, 2019

Do you have a particular example of an error you get?

@jlibovicky
Copy link
Contributor

If everything works correctly, the loss ops are prepared as potential fetches in the runner, but at the time the runner creates an executable, it knows whether the reference is available or not and sets flag compute_losses accordingly. If there is no reference, the executable replaces the ops with tf.zeros([]).

@varisd
Copy link
Member Author

varisd commented Mar 18, 2019

I'll try to find a reproducible example.

@jindrahelcl
Copy link
Member

jindrahelcl commented Mar 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants