Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Undo does not follow history/timeline #1395

Open
2 tasks done
mvhulten opened this issue Mar 12, 2022 · 1 comment
Open
2 tasks done

Undo does not follow history/timeline #1395

mvhulten opened this issue Mar 12, 2022 · 1 comment

Comments

@mvhulten
Copy link

I'm opening this issue because:

  • I'll report a bug
  • I'll propose a new feature

Description

When I have two Firefox windows open (same session), both with its own actual tab history, pressing U (undo) in one window undoes and action in either of the two windows without regard of

  1. which window is active
  2. the actual timeline of changes (of both windows together)

Number (1) is not a bug per se but rather a feature request. I think it is most intuitive if the undo action looks at the history of the active window.

Failure Information (for bugs)

Steps to Reproduce

Number (2) can be reproduced by

  • opening Firefox
  • creating some tab history in one window
  • open another window and create more history
  • quit Firefox (saving the state with all open windows/tabs)
  • restart Firefox
  • make more history in the second window
  • press U
  • press U
  • ...

Even though undos are expected to happen according to the history/timeline (in reversed order), my experience is that undos occur in the first window even as this is ancient history that should not take precedence over the second window's history.

System configuration

  • Operating system: OpenBSD current

  • Firefox version: firefox-esr-91.7.0

  • Vim-Vixen version: 1.2.3

  • Operating system: Guix System

  • Firefox version: 91.6.0esr (64-bit)

  • Vim-Vixen version: 1.2.3

Console logs

@mvhulten
Copy link
Author

The problem is still present in Firefox 102.6.0esr. The newest Vim Vixen version/tag 1.2.4 is not available on addons.mozilla.org and thus I have tested only with 1.2.3.

To recap/simplify, the undo u should follow the history of the current window. This implies that histories should be recorded for different browser windows.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant