Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Add ability to disable conflicting keybindings for some websites #1392

Open
1 of 2 tasks
IzhakJakov opened this issue Mar 10, 2022 · 10 comments
Open
1 of 2 tasks

Add ability to disable conflicting keybindings for some websites #1392

IzhakJakov opened this issue Mar 10, 2022 · 10 comments

Comments

@IzhakJakov
Copy link

I'm opening this issue because:

  • I'll report a bug
  • I'll propose a new feature

Description

I would like to be able to disable keybindings on some websites that conflict with Vixen
As shown in the PR for videospeed extension.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Go to www.youtube.com
  2. Play a video
  3. Go down to read comments by using J
  4. The video should now rewind 10secs as documented here

System configuration

  • Operating system: MacOS
  • Firefox version: 98
  • Vim-Vixen version: 1.2.3
@ouuan
Copy link

ouuan commented Apr 4, 2022

@IzhakJakov
Copy link
Author

Thank you for you post @ouuan but I am not looking for disabling the plugin on certain websites. What I would like to do is disable the keybindings on certain websites that conflict with Vixen.

Similar to what the extension Video Speed Controller is doing when using "Disable website key bindings"
image

@ouuan
Copy link

ouuan commented Apr 4, 2022

Isn't Vim Vixen already overriding the website's keybindings when there are conflicts?

@IzhakJakov
Copy link
Author

Not in the example I provided. You can checkout "Steps to Reproduce".
Maybe there is something I am suppose to enable?

@ouuan
Copy link

ouuan commented Apr 4, 2022

Not in the example I provided. You can checkout "Steps to Reproduce".

I'm also able to reproduce it. However, on most sites except Youtube, the website's keybindings are overridden.

@IzhakJakov
Copy link
Author

I had this issue in other websites as well
Can you provide an example website where these keybindings are overwritten?

@ouuan
Copy link

ouuan commented Apr 5, 2022

Can you provide an example website where these keybindings are overwritten?

GitHub is an example.

@IzhakJakov
Copy link
Author

Which keybindings are overwritten?

@ouuan
Copy link

ouuan commented Apr 5, 2022

Which keybindings are overwritten?

Press "?" to see the list. I think all conflicts are overridden. j, k, t, for example.

@IzhakJakov
Copy link
Author

Nice, I was not aware of ? 😃
Also good example. Thank you!

I wonder why it does not disable YT's annoying keybindings 🤨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants