Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of blank line at end of file can cause failure of added material #2637

Open
drnorthcutt opened this issue Oct 19, 2015 · 5 comments
Open

Comments

@drnorthcutt
Copy link
Contributor

Love the idea. But... I noticed that:

Numerous pages end without a blank line under the content. New material cannot be added below the current content, since adding a line is the equivalent of deleting the current last line and rewriting it with a line return.

To prevent this, Casey could perhaps be modified to automatically add a blank line to the end of a page, or could require that a blank line be added before resubmission.

@ccc0der
Copy link

ccc0der commented Jan 25, 2016

I've finished fixing my pull request. Only changed lines issues are still pending, but those deletions are links to my part of the story. Please, approve the pull request

@johngUK
Copy link

johngUK commented Jan 28, 2016

Added blank line to end of File.
Thanks for suggestion!

@morosebose
Copy link
Contributor

@casey-collab

@brigdev
Copy link
Contributor

brigdev commented Jun 28, 2016

This was an issue for me as well. Couldn't get Casey to accept my pull request because of this.

@Cordcouch
Copy link

Cordcouch commented Mar 20, 2017

Same issue for me as well. Currently there is no blank line at the end of marshmallow.md
So if I add new content to the end of the the file "git diff" thinks I deleted the last last line and rewrote it with a line return.
This way however casey-collab won't commit my pull request!

Btw: Pull request #7084 has the same issue I think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants