Students Grades Disappear After Unenrolled

[atkoehler]

So this is a situation that might require discussion or thought. The most general case is, "Should grades and submissions for unenrolled students still be accessible?"

Here is a slightly more specific but still generalized case:

Student enrolled in cs010_13fal switches to online cs010v_13fal. Thus the student is unenrolled from the normal class. The grades for that student are still valid in cs010 and are not accessible since that student is no longer enrolled in the course. The grades need to be transferred to the different course as they are applicable but there is no way to access the grades and not clutter the students Galah interface with turn-ins for both courses.

That is the general case, but I didn't want to say Class A and Class B; it makes more sense with 10 and 10v. The more specific case is that the student is now back in CS 10 and has completed some assignments in 10 to start with, then 10v and will now be submitting the remainder in 10. I will probably be handling this specific case individually and just sitting down with her and downloading all submitted assignments and reuploading them after using modify_user_deadline.

[itsjohncs]

If you re-enroll the students the grades should become available again.

See the drop_student implementation at https://github.com/galah-group/galah/blob/v0.2stable/galah/web/api/commands.py#L598

For now, this should be sufficient, but this use case could use something specific to take care of it.

[itsjohncs]

I think the feature we want is already described well in #378 so closing this issue as a duplicate.

[atkoehler]

I was thinking more along the lines of... the student drops the course. Therefore he or she should be removed from R'Sub. This unenrollment will cause the grades to disappear but they shouldn't the submission and grades are still relevant to the class... especially in cases of cheat checking. So should the student be completely unenrolled? They shouldn't be able to submit anymore, they aren't enrolled but they should have access to their old submissions as well as their grades, IMO... same goes for instructors looking for those students.

I haven't checked but if I would assume since I can't find a student's feedback if they aren't enrolled then I also don't get the submissions when they are all downloaded.

I hope that makes sense.

[itsjohncs]

I think I understand, and this goes with one of Galah's unspoken goals of not destroying data when possible. I'll repoen this issue.