Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo (either in model training tutorial or embedding module) #392

Open
antonyscerri opened this issue Sep 21, 2018 · 0 comments
Open

Comments

@antonyscerri
Copy link

I noticed whilst tweaking some code that there is a typo in one of two places. I suspect it's the notebook jack/notebooks/model_training.ipynb there is a call to load_embeddings but it passes in type='glove' however the respective function uses "typ" for the second parameter (which i assume is deliberate to avoid conflicting with Python's type class).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant